Add CMake flag to enable/disable hpc synapses #1049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you keep it enable by default? I’m one of those HPC users.
…On Tue, Oct 16, 2018 at 7:11 Jakob Jordan ***@***.***> wrote:
under the assumption that most users do not use the hpc versions of the
synapses, this PR adds a cmake option to enable/disable(default) hpc
synapse models. this allows for more custom models to be registered before
running out of possible synapse models. partly addresses #1043
<#1043>
------------------------------
You can view, comment on, or merge this pull request online at:
#1049
Commit Summary
- Add CMake flag to enable/disable hpc synapses
File Changes
- *M* CMakeLists.txt
<https://github.com/nest/nest-simulator/pull/1049/files#diff-0> (3)
- *M* cmake/ProcessOptions.cmake
<https://github.com/nest/nest-simulator/pull/1049/files#diff-1> (9)
- *M* libnestutil/config.h.in
<https://github.com/nest/nest-simulator/pull/1049/files#diff-2> (3)
- *M* models/modelsmodule.cpp
<https://github.com/nest/nest-simulator/pull/1049/files#diff-3> (48)
Patch Links:
- https://github.com/nest/nest-simulator/pull/1049.patch
- https://github.com/nest/nest-simulator/pull/1049.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1049>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6w51atAlpYr1pX3iTTsm8PyR9bIhsNks5ulQf8gaJpZM4XdPAv>
.
|
|
That’d be least intrusive.
On Tue, Oct 16, 2018 at 7:49 Itaru Kitayama <[email protected]>
wrote:
…
Could you keep it enable by default? I’m one of those HPC users.
On Tue, Oct 16, 2018 at 7:11 Jakob Jordan ***@***.***>
wrote:
> under the assumption that most users do not use the hpc versions of the
> synapses, this PR adds a cmake option to enable/disable(default) hpc
> synapse models. this allows for more custom models to be registered before
> running out of possible synapse models. partly addresses #1043
> <#1043>
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #1049
> Commit Summary
>
> - Add CMake flag to enable/disable hpc synapses
>
> File Changes
>
> - *M* CMakeLists.txt
> <https://github.com/nest/nest-simulator/pull/1049/files#diff-0> (3)
> - *M* cmake/ProcessOptions.cmake
> <https://github.com/nest/nest-simulator/pull/1049/files#diff-1> (9)
> - *M* libnestutil/config.h.in
> <https://github.com/nest/nest-simulator/pull/1049/files#diff-2> (3)
> - *M* models/modelsmodule.cpp
> <https://github.com/nest/nest-simulator/pull/1049/files#diff-3> (48)
>
> Patch Links:
>
> - https://github.com/nest/nest-simulator/pull/1049.patch
> - https://github.com/nest/nest-simulator/pull/1049.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#1049>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA6w51atAlpYr1pX3iTTsm8PyR9bIhsNks5ulQf8gaJpZM4XdPAv>
> .
>
|
|
thanks for the comment @ikitayama. i think this is a matter of taste. since most users will not use hpc synapses, and those who do, including you, know how to adjust cmake options to their desire, I thought it would be more reasonable to set the default to off, but I am open to discuss this. |
|
@jakobj - I suppose a new CMake variable would be easily overlooked thus ended up a binary that is built to not load the HPC-themed models. And an HPC user might waist his/her couples of hours wondering at to why the models aren't loaded at run time. This is the scenario I worry about. Given that we'd let many modules piled up in the code base, I'd like to oppose introducing module |
stinebuu
added
ZC: Installation
|
closing, see #1043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
under the assumption that most users do not use the hpc versions of the synapses, this PR adds a cmake option to enable/disable(default) hpc synapse models. this allows for more custom models to be registered before running out of possible synapse models. partly addresses #1043
@heplesser @suku248