Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional travis builds using build stages #1111

Merged
merged 23 commits into from
Feb 21, 2019

Conversation

lekshmideepu
Copy link
Contributor

Added four build stages:
* Static code analysis check
* MPI and Threading (5 different jobs)
* Full builds for Python 3.4.4 and Python 2.7.13
* cpp builds for GCC 8 and Clang 7 (2 jobs)

@lekshmideepu lekshmideepu added ZC: Infrastructure DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jan 30, 2019
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good to me. I'm merging without second review as this PR mainly restructures the way our CI jobs run without adding or modifying functionality. It also cuts down on run times and gives us quicker failing on errors right away. We can always improve upon this if needed.

@jougs jougs merged commit e1198a0 into nest:master Feb 21, 2019
@jougs
Copy link
Contributor

jougs commented Feb 21, 2019

@lekshmideepu: nice PR number, btw 😸

@lekshmideepu
Copy link
Contributor Author

Thanks for the review @jougs

@terhorstd terhorstd added T: Enhancement New functionality, model or documentation ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority labels Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation ZC: Infrastructure DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants