Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on how to create C++-level unit tests #1172

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Add documentation on how to create C++-level unit tests #1172

merged 1 commit into from
Apr 10, 2019

Conversation

hakonsbm
Copy link
Contributor

Added documentation on how to create C++ unit tests using the Boost.Test framework.

Fixes #1045.

Silmathoron
Silmathoron reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@Silmathoron Silmathoron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear to me, maybe you could just add that the tests are in testsuite/cpptests...

@hakonsbm
Copy link
Contributor Author

@Silmathoron Isn't that clear from the first sentence?

This directory contains C++-level unit tests.

@Silmathoron
Copy link
Member

Silmathoron commented Apr 10, 2019 •
edited
Loading

I don't know... my general approach is that explicit is always better if it doesn't cost anything (which I think is the case here) ;)

EDIT: forget it, I'm tired...

Silmathoron
Silmathoron approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@Silmathoron Silmathoron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that my previous remark was stupid, I think this doc is good and can be included as is ;)
👍

@heplesser heplesser added ZC: Documentation DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Apr 10, 2019
@heplesser heplesser changed the title Documentation on how to create C++-level unit tests Add documentation on how to create C++-level unit tests Apr 10, 2019
@heplesser heplesser merged commit bea7e18 into nest:master Apr 10, 2019
@hakonsbm hakonsbm deleted the cpp_tests_doc branch April 11, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Silmathoron Silmathoron Silmathoron approved these changes

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation ZC: Documentation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hakonsbm @Silmathoron @heplesser