Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace iaf_neuron by iaf_psc_alpha in MUSIC tutorial #1330

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Replace iaf_neuron by iaf_psc_alpha in MUSIC tutorial #1330

merged 1 commit into from
Nov 5, 2019

Conversation

steffengraber
Copy link
Contributor

@steffengraber steffengraber commented Oct 31, 2019 •
edited
Loading

This is only a very small change to the documentation.
In the example, the obsolete iaf_neuron is replaced by iaf_psc_alpha. (Compare PR #526)
With this I was able to reproduce the example.

@steffengraber steffengraber added ZC: Documentation DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Oct 31, 2019
jougs
jougs approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this slipped in due to the removal of the iaf_neuron in the repository and the addition of the MUSIC tutorial being in separate PRs. Anyway, thanks for catching and fixing this.

@jougs jougs removed the request for review from jessica-mitchell November 5, 2019 14:22
@jougs jougs merged commit 909fa52 into nest:master Nov 5, 2019
@steffengraber steffengraber deleted the fix-music-tutorial branch September 6, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Documentation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steffengraber @jougs