-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving to Python3.x on OsX #1335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lekshmideepu: Many, many thanks! I have two very minor suggestions to the wording of comments. Other than those I'm fine.
@heplesser, @stinebuu, @hakonsbm: Could one of you have a quick look as well? This will most likely fix the current failures of nest-3 and nestio builds and get us one step closer to done :-)
.travis.yml
Outdated
osx_image: xcode10.2 | ||
language: generic | ||
osx_image: xcode10.3 # Python 3.7.4 running on macOS 10.14.4 | ||
language: shell # 'language: python' is an error on Travis CI macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
language: shell # 'language: python' is an error on Travis CI macOS | |
language: shell # languages 'generic' or 'python' result in errors on macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jougs Thanks for reviewing. language: generic
works in general for OsX. Our current setup uses it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lekshmideepu I approve, conditional on changes by Jochen being accepted.
Co-Authored-By: Jochen Martin Eppler <[email protected]>
Thanks for the review @heplesser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very tiny grammar thing left. Thanks!
osx_image: xcode10.2 | ||
language: generic | ||
osx_image: xcode10.3 # Python 3.7.4 running on macOS 10.14.4 | ||
language: shell # language 'python' result in errors on macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
language: shell # language 'python' result in errors on macOS | |
language: shell # language 'python' results in errors on macOS |
I'll fix the grammar after the merge. |
Thanks :-) |
At the moment OsX build uses Python2.x. This PR will fix one of the task in #1313 and #1325