Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to Python3.x on OsX #1335

Merged
merged 4 commits into from
Nov 8, 2019
Merged

Moving to Python3.x on OsX #1335

merged 4 commits into from
Nov 8, 2019

Conversation

lekshmideepu
Copy link
Contributor

@lekshmideepu lekshmideepu commented Nov 7, 2019

At the moment OsX build uses Python2.x. This PR will fix one of the task in #1313 and #1325

Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lekshmideepu: Many, many thanks! I have two very minor suggestions to the wording of comments. Other than those I'm fine.

@heplesser, @stinebuu, @hakonsbm: Could one of you have a quick look as well? This will most likely fix the current failures of nest-3 and nestio builds and get us one step closer to done :-)

.travis.yml Outdated
osx_image: xcode10.2
language: generic
osx_image: xcode10.3 # Python 3.7.4 running on macOS 10.14.4
language: shell # 'language: python' is an error on Travis CI macOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
language: shell # 'language: python' is an error on Travis CI macOS
language: shell # languages 'generic' or 'python' result in errors on macOS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jougs Thanks for reviewing. language: generic works in general for OsX. Our current setup uses it.

.travis.yml Outdated Show resolved Hide resolved
@jougs jougs added ZC: Infrastructure DO NOT USE THIS LABEL I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know ZP: PR Created DO NOT USE THIS LABEL S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. labels Nov 8, 2019
@jougs jougs added this to the NEST 3.0 milestone Nov 8, 2019
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lekshmideepu I approve, conditional on changes by Jochen being accepted.

Co-Authored-By: Jochen Martin Eppler <[email protected]>
@lekshmideepu
Copy link
Contributor Author

@lekshmideepu I approve, conditional on changes by Jochen being accepted.

Thanks for the review @heplesser

Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very tiny grammar thing left. Thanks!

osx_image: xcode10.2
language: generic
osx_image: xcode10.3 # Python 3.7.4 running on macOS 10.14.4
language: shell # language 'python' result in errors on macOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
language: shell # language 'python' result in errors on macOS
language: shell # language 'python' results in errors on macOS

@jougs
Copy link
Contributor

jougs commented Nov 8, 2019

I'll fix the grammar after the merge.

@jougs jougs merged commit c78ef22 into nest:master Nov 8, 2019
@clinssen clinssen mentioned this pull request Nov 8, 2019
7 tasks
@lekshmideepu
Copy link
Contributor Author

I'll fix the grammar after the merge.

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. ZC: Infrastructure DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants