Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting script in profile.d during uninstallation of the NEST .deb package #1363

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Deleting script in profile.d during uninstallation of the NEST .deb package #1363

merged 1 commit into from
Dec 12, 2019

Conversation

steffengraber
Copy link
Contributor

During the installation of the .deb package with apt install nest, a shell script is written to /etc/profile.d, which ensures that the correct environment variables are set for NEST every time the system boots.
This file is now removed during the uninstallation of the package with apt remove nest.

@heplesser heplesser requested a review from jougs December 11, 2019 22:43
@heplesser heplesser added ZC: Installation DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Dec 11, 2019
jougs
jougs approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@jougs jougs merged commit dc212c0 into nest:master Dec 12, 2019
@steffengraber steffengraber deleted the fix-deb-uninstall branch September 6, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Installation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steffengraber @heplesser @jougs