Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Izhikevich model initial conditions #1626

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Conversation

clinssen
Copy link
Contributor

Presently, the Izhikevich neuron model does not start at equilibrium: the initial conditions for V and U are such that there is an initial transient, before the system settles to steady-state.

This PR proposes to change the default initial conditions such that the initial state is stable.

@clinssen clinssen changed the title fix Izhikevich model initial conditions Fix Izhikevich model initial conditions May 27, 2020
@stinebuu stinebuu added I: Behavior changes Introduces changes that produce different results for some users S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Jun 10, 2020
@terhorstd terhorstd requested a review from gtrensch June 22, 2020 09:58
models/izhikevich.cpp Outdated Show resolved Hide resolved
@terhorstd terhorstd requested review from gtrensch and suku248 and removed request for suku248 July 1, 2020 08:21
@terhorstd
Copy link
Contributor

one reviewer is enough for this change.

Copy link
Contributor

@gtrensch gtrensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Approving.

@stinebuu stinebuu merged commit b3571cf into nest:master Jul 1, 2020
clinssen added a commit to clinssen/nestml that referenced this pull request Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: Behavior changes Introduces changes that produce different results for some users S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants