Add description for "Two neuron example" #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarakonradi
suggested changes
Nov 3, 2020
There was a problem hiding this comment.
@YounesBouhadjar Thanks a lot for this! Looks good overall. Just added some minor suggestions and PEP8-related comments.
Co-authored-by: sarakonradi <[email protected]>
sarakonradi
reviewed
Nov 3, 2020
Co-authored-by: sarakonradi <[email protected]>
sarakonradi
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
LGTM 👍
It is passing the Travis checks, apart from the usual macOS issues. @hakonsbm What do you think?
stinebuu
added
I: No breaking change
hakonsbm
suggested changes
Nov 4, 2020
hakonsbm
suggested changes
Nov 4, 2020
Co-authored-by: Håkon Bakke Mørk <[email protected]>
hakonsbm
approved these changes
Nov 5, 2020
|
This only affects Python documentation, so we can ignore the failing macOS CI stage (see #1822) and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1754
and minor corrections of
one_neuron.pydocumentation