Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised documentation on synapse specification slightly #1902

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

heplesser
Copy link
Contributor

I tried to clarify the guide on synapse specifications a bit and replaced "distributions" with "expressions", since our mechanism is far more general than random distributions.

@heplesser heplesser added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 1, 2021
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @heplesser! I'm fine with this, but you have written that a synapse dictionary must contain synapse_model, and this is not necessary.

doc/guides/connection_management.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Copy link
Contributor

@sarakonradi sarakonradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just added a (very minor) suggestion.

@stinebuu stinebuu merged commit 8ea5ba9 into nest:master Feb 5, 2021
@heplesser heplesser deleted the improve-conn-doc branch February 25, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants