-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a NEST documentation style guide #1986
Conversation
@jessica-mitchell Thanks for all the fixes! But I still see no bullet points in the rendered lists. Looking at the HTML code reveals that the lists are properly encoded as lists, but with
in |
Points still in need of discussion:
|
…ide folders, apply suggestions from ovdc
…ur from non-linked items
…nces, emphasis and backticks
@jessica-mitchell: would it be possible to post a link to a rendered version? Thanks! |
Yes, here you go: https://nest-test.readthedocs.io/en/nest_styleguide/contribute/styleguide/styleguide.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many links in the document to external resources, consider gathering all of them in the References section at the bottom of the document.
@clinssen most of your suggestion I added (see exceptions in comments above), including references at the bottom of the page. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jessica-mitchell Just a few more details ;).
@heplesser I applied your suggestions, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jessica-mitchell Great work!
@terhorstd @jougs You are either set up as reviewers or have commented earlier on the style guide. Do you still want to review/comment or can we go ahead and merge this one with two approvals in place? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor remarks. Since those are not critical we could also add them incrementally. Add them if possible.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! I have added some minor suggestions.
We've been discussing having a style guide for quite some time with the aim to help reduce inconsistencies in documentation writing.
This PR introduces a style guide inspired from several other style guides around the interwebs.
It includes several sections regarding English language as well as formatting and markup notation.
Please note:
There is a lot that still needs to be discussed here! @jougs @heplesser @terhorstd I'm sure you all have thoughts on this topic.
Any information that is missing? Anything too excessive?
Do we want to use an external style guide (like Microsoft's or Google's style guide) as a reference, in case people run into questions we do not address in our style guide?
Some of the choices like formatting marks made here are based on what we do usually or what has been discussed, but obviously we can make changes as we see fit. We just need to make sure that readability is improved with the choices we make not impeded.
Thanks to @sarakonradi for contributing to this as well.