Fix build log parser failed test list #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonsbm
added
T: Bug
heplesser
reviewed
Jun 14, 2021
There was a problem hiding this comment.
@hakonsbm Thanks for this! A few questions:
- Should we add a version requirement to junitparser in the right places?
- Have you tested this by breaking a few tests?
- Are we sure we will only ever need element [0] from the list?
Done!
Yes, to find out what caused this I had to break a few
Right now it seems like each testcase always give at most one result and skipped tests give exactly one result. |
heplesser
reviewed
Jun 14, 2021
heplesser
reviewed
Jun 14, 2021
heplesser
approved these changes
Jun 14, 2021
|
Minimal but important fix to test reporting, therefore merging based on single review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1945 by updating the
summarize_tests.pyscript forjunitparserversion 2.0. With version 2.0 ofjunitparsercase.resultis changed to a list. This caused skipped tests to not be detected as skipped, and therefore added to the list of failing tests which is printed if any other tests fail.