Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting of PYEXECDIR #2080

Merged
merged 5 commits into from
Jun 17, 2021
Merged

Fix setting of PYEXECDIR #2080

merged 5 commits into from
Jun 17, 2021

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Jun 16, 2021 •
edited
Loading

During #1959 I hardcoded CMAKE_INSTALL_LIBDIR to lib as it was unavailable during nest_process_with_python but this led to problems for several environments. Now PYEXECDIR is after the GNUInstallDirs have been included.

Closes #2075, closes #2079

heplesser
heplesser approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@heplesser heplesser added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation labels Jun 16, 2021
@heplesser heplesser added this to the NEST 3.1 milestone Jun 16, 2021
jasperalbers
jasperalbers approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@jasperalbers jasperalbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as expected for me.

@heplesser heplesser merged commit 2e7316f into nest:master Jun 17, 2021
@Helveg Helveg deleted the python-libdir branch June 17, 2021 15:11
@terhorstd terhorstd changed the title Fixed PYEXECDIR Fix setting of PYEXECDIR Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperalbers jasperalbers jasperalbers approved these changes

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Installation
Status: Done
Milestone
NEST 3.1
3 participants
@Helveg @heplesser @jasperalbers