Minor improvement to microcircuit example

[morales-gregorio]

As mentioned in #1207 the examples code has already improved significantly and I could only identify one place where a warning would be fitting.

Additionally I spotted one superfluous import.

Best,
Aitor

[morales-gregorio]

I have changed the problematic files from #1208 in this PR too. The PBS part was removed and writing the submission file is something the user will have to do own their own.

[stinebuu]

Thanks! I have two small formatting comments, but otherwise it looks good :)

[stinebuu]

Thanks!

[stinebuu]

@morales-gregorio Just noticed that GitHub actions complains about some pep8 formatting errors in network.py. Could you check that? If it is the line break I made you revert I apologize! I did not check how long the line was before I asked you to put it in one line.

[morales-gregorio]

Hi @stinebuu I see all the PEP8 errors refer to line breaks after a binary operator:

MSGBLD0195: [PEP8] pynest/examples/Potjans_2014/network.py:193:72: W504 line break after binary operator
MSGBLD0195: [PEP8] pynest/examples/Potjans_2014/network.py:195:57: W504 line break after binary operator
MSGBLD0195: [PEP8] pynest/examples/Potjans_2014/network.py:196:66: W504 line break after binary operator
MSGBLD0195: [PEP8] pynest/examples/Potjans_2014/network.py:198:63: W504 line break after binary operator
MSGBLD0195: [PEP8] pynest/examples/Potjans_2014/network.py:329:46: W504 line break after binary operator
MSGBLD0195: [PEP8] pynest/examples/Potjans_2014/network.py:423:56: W504 line break after binary operator
MSGBLD0195: [PEP8] pynest/examples/Potjans_2014/network.py:452:71: W504 line break after binary operator
MSGBLD0195: [PEP8] pynest/examples/Potjans_2014/network.py:459:79: W504 line break after binary operator
MSGBLD0195: [PEP8] pynest/examples/Potjans_2014/network.py:522:62: W504 line break after binary operator

Such as:

        self.num_neurons = np.round((self.net_dict['full_num_neurons'] *
                                     self.net_dict['N_scaling'])).astype(int)

But all of these happen within parentheses, so python will have no problem interpreting them :/
The line lengths seem fine :)

I would not force a \ after each of these binary operators since they are not needed for python to work and make the code cluttered. Maybe the PEP8 checker in Github actions needs to be updated ;)

[heplesser]

@morales-gregorio No, we definitely don't want to introduce line continuation by \. But PEP8 states that when you break on a binary operator, the operator shall be at the beginning of the second line:

self.num_neurons = np.round((self.net_dict['full_num_neurons']
                             * self.net_dict['N_scaling'])).astype(int)

When fixing this, make sure you don't leave whitespace at the end of the first line or PEP8 will complain about that ;).

[morales-gregorio]

Hi! I think all the tests now pass, from my side it can be merged

[jougs]

@jhnnsnk: friendly ping!

[jhnnsnk]

👍
Looks good to me. Thanks, @morales-gregorio, for the improvements (and thanks, @jougs, for the ping)!