Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo Markdown-to-reStructuredText conversion in doxygen comment #2112

Merged
merged 4 commits into from
Jul 23, 2021

Conversation

clinssen
Copy link
Contributor

This reverts commit c2b6b7e.

Sadly, doxygen does not (transparently) support reStructuredText for code comments yet, so the rST does not render well in the doxygen HTML output.

As observantly pointed out by @jougs!

Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clinssen - this looks good to me. I took the opportunity to suggest a few language improvements, but I will approve since it's very minor.

sli/token.h Outdated Show resolved Hide resolved
sli/token.h Outdated Show resolved Hide resolved
sli/token.h Outdated Show resolved Hide resolved
@jessica-mitchell jessica-mitchell added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Jul 23, 2021
@clinssen
Copy link
Contributor Author

Thanks, all suggestions applied!

@jougs jougs merged commit f75bfc3 into nest:master Jul 23, 2021
@jougs jougs added this to the NEST 3.1 milestone Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants