Changes to fix the hard coded decay of synaptic elements #215
Conversation
| @@ -47,7 +47,7 @@ nest::SynapticElement::SynapticElement() | |||
| , z_connected_( 0 ) | |||
| , continuous_( true ) | |||
| , growth_rate_( 1.0 ) | |||
| , tau_vacant_( 10.0 ) | |||
| , tau_vacant_( 0.1 ) | |||
There was a problem hiding this comment.
@sdiazpier I am a bit surprised by the change of the default value of tau_vacant_ from 10.0 to 0.1. This probably has no consequence, since the value was not used anywhere in the past, but could you just confirm that the change is intentional?
There was a problem hiding this comment.
Hi dear @heplesser, yes you are right, the change is intentional. This value was unused, but it was part of the original design. This change was done in order to adapt the value to the current implementation of the decay.
|
I think @jakobj would be a good second reviewer. |
|
i agree with @heplesser's suggestion to introduce the |
…update is handled directly inside the SynapticElements class
|
Dear @jakobj and @heplesser, thank you for your comments. I have done and submitted the changes you suggested. Please let me know if anything else is missing. |
|
looks good to me 👍 |
|
Thank you! 👍 |
Changes to fix the hard coded decay of synaptic elements
This pull request addresses issue #214 , now allowing the user to set the amount using the tau_vacant variable in the synaptic elements class.