Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEST wheels #2170

Closed
wants to merge 77 commits into from
Closed

NEST wheels #2170

wants to merge 77 commits into from

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Sep 23, 2021 •
edited
Loading

Progress

  • Produce wheels in slightly modified NEST temporarily checked out repository ("wheel building env") with scripted modifications to be correctly processed by cibuildwheel
  • Manylinux wheels using cibuildwheel
  • (blocking) Make NEST wheel work with paths relative to single arbitrary deploy location
    • Requires excision of SLI from Python interface
    • Undefined Python API symbols (link error?)
  • Expand wheelhouse
    • i868/32bit support
    • musllinux support (Alpine)
  • Verify PyPI publishing on test PyPI.
  • Add cibuildwheel test command.
  • Eliminate CMake processing of Python codebase, reduces build time and simplifies build process.

Resources

Robin De Schepper and others added 30 commits September 23, 2021 21:53
Added wheel build environment to .gitignore
f7422fe 
Useful for local testing
Cache PYEXECDIR to allow Python to fish it out of CMake
17a2643
Vendor deprecated distutils, useful for making distributions.
ac9da28
Added script to prepare the wheel build environment
0983f78 
* Fishes some CMAKE vars, `setup.py` and the NEST Python code out of the 
NEST build folder
* Clones a clean repo
* Modifies this repo to be able to build wheels
* Copies over fished up goodies
Build wheel protocol to be executed by CI
a25e1b9
Added CMake rig to setup.py. Only executed on wheel build.
fb5ee3e
Actually use the rigged class
6345f85
Fixed install location and RPATH of pynestkernel.so during buildwheel
aed3c45
@Helveg
Clone wheel env: current commit from current remote
a3e7352
@Helveg
include sli in package
8256081
@Helveg
set env var before py script
294712a
@Helveg
make full clone
db7f135
@Helveg
Read NEST_CMAKE_BUILDWHEEL from env
966e7ab
@Helveg
Install the Python source code to copy it. Auto detect all packages.
1aa2028
@Helveg
CI attempt
5688e1f
@Helveg
Set install prefix for tmp wheel env
5495e5b
@Helveg
copyright headers
0c66356
@Helveg
pip install wheel and cython
cb5beb3
@Helveg
Install libomp-dev
7f35f5e
@Helveg
Fix MacOS OpenMP install command
3fb809c
@Helveg
didn't source'ing work?
cda72f8
@Helveg
Install with -j4, set buildwheel env var in cibuildwheel options.
ce90ab1
@Helveg
Hardcoded semver as a solution to obtain wheels
88fd2eb
@Helveg
Get Python libraries
d283c70
Guard commit SHA race conditions on GHA by using actions/checkout.
9ea1086
fixed uses/run combo
b65ee64
fixed prep_wheel_env changes
6b606ed
no sudo on GHA
4c9b042
use yum on manylinux_2010
a7c5800
@Helveg
Added cibuildwheel wheels
2026e35 
* Added/vendored `copy_nest_tree` to copy`.py` and `.sli` files.

* Run an initial CMake build to obtain the Python build files.

* Added a wheel building environment. Rigged `setup.py.in` and the `CMake` build to cooperate and produce the wheel building environment. This environment is a new nest repository where the `setuptools` and `CMake` build files have been lined up to be copied into the `manylinux`wheel building Docker images.

* Use `cibuildwheel` to run our `CMake`/`setuptools` hybrid build and produce a wheelhouse.
jougs and others added 17 commits October 22, 2021 14:43
@jougs
Move PyNEST initializer code for SLI to standard NEST initializer (#3)
e702eb5
@terhorstd
stop clang-format from asking to break the code
cbd7ffd
@terhorstd
change inline.py file handling
01013c0
@Helveg
Merge branch 'sli-init-inlining' into circular-wheels
9c23c1c
@terhorstd
Merge branch 'circular-wheels' into sli-init-inlining
c1c0af0
@jougs
Remove unused argument modulepath
8dadbf1
@jougs
Merge branch 'circular-wheels' of https://github.com/Helveg/nest-simu…
d594c97 
…lator into circular-wheels
@terhorstd
fix indent typo
cbed9fd
@terhorstd
Merge branch 'sli-init-inlining' of github.com:terhorstd/nest-simulat…
9d74cbe 
…or into sli-init-inlining
@Helveg
Merge branch 'sli-init-inlining' into circular-wheels
326bb76
@Helveg
Merge remote-tracking branch 'jougs/circular-wheels' into circular-wh…
5b1a007 
…eels
@Helveg
Inlined SLI code for wheel build
a205b30
@Helveg
Fix kwarg order for non kwarg calls
eee711f
@Helveg
Skip unsupported <3.8 Python wheels
3222d80
@Helveg
static code analysis fixes
4d17035
@Helveg
Hatcheting some run statements in examples and doc top prevent inline
61b69ef
@Helveg
Merge branch 'master' into circular-wheels
f63c2e7
@stinebuu stinebuu added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Dec 6, 2021
@jougs jougs mentioned this pull request Dec 19, 2021
Open
@github-actions
Copy link

github-actions bot commented Feb 5, 2022

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Feb 5, 2022
@Helveg
Copy link
Contributor Author

Helveg commented Nov 28, 2022 •
edited
Loading

Closing this, as it will be superceded in the near future by a collective effort.

@Helveg Helveg closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Enhancement New functionality, model or documentation
Projects
Installation
Status: Done
PyNEST
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Helveg @stinebuu @terhorstd @jougs