Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed object base from class argument lists #2221

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Removed object base from class argument lists #2221

merged 1 commit into from
Nov 26, 2021

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Nov 26, 2021

In Python 3 all classes have object added into their bases implicitly. There is no need to declare it explicitly. I left it in in the ConnPlotter files as not to conflict with #2147

heplesser
heplesser approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up!

@heplesser
Copy link
Contributor

Since this is an absolutely straightforward clean-up, I merge without second review.

@heplesser heplesser merged commit 76187d9 into nest:master Nov 26, 2021
@Helveg Helveg deleted the remove-py2class branch November 26, 2021 12:43
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Helveg @heplesser @terhorstd