Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return invalid_thread_ for proxynode #2296

Closed
wants to merge 1 commit into from
Closed

Return invalid_thread_ for proxynode #2296

wants to merge 1 commit into from

Conversation

StefanBruens
Copy link

Not returning in a non-void function causes undefined-behavior.

Fixes #2295

@StefanBruens
Return invalid_thread_ for proxynode
7c3f74e 
Not returning in a non-void function causes undefined-behavior.

Fixes nest#2295
@stinebuu stinebuu added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Feb 22, 2022
@stinebuu
Copy link
Contributor

Thanks @StefanBruens! Could you also fix the one in node.cpp you mentioned in the issue? You can then return -1.

@clinssen
Copy link
Contributor

clinssen commented Mar 7, 2022

@StefanBruens: gentle ping!

@jougs
Copy link
Contributor

jougs commented Mar 21, 2022

@StefanBruens: could you please update this PR as requested by @stinebuu? Many thanks!

@heplesser heplesser mentioned this pull request Apr 21, 2022
Merged
@heplesser
Copy link
Contributor

I am closing this PR due to inactivity. #2376 replaces it and addresses all issues mentioned in #2295.

@heplesser heplesser closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinebuu stinebuu Awaiting requested review from stinebuu

@jougs jougs Awaiting requested review from jougs

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proxynode::get_thread should return defined value (or throw)
5 participants
@StefanBruens @stinebuu @clinssen @jougs @heplesser