Temporary fix for noqa problems. #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
S: Critical
|
Not sure we should merge this, given that help is on the way and will probably arrive later this week. |
Maybe we can keep it open but not merged, so we can merge it in case CI for other PRs is blocked by this problem. |
jougs
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Given that the other PR will probably still take some time and that the file in which this change is will be removed from the repository in that PR, I am now approving to reduce the annoyance by this nasty error. I'm also merging immediately, as the change does not concern the simulation code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a temporary fix for the PEP8/noqa problem described in #2175, which currently leads to CI failure for many PRs. It brute-force ignores the problematic file.
This should be reversed as soon as a proper fix is in place (flake8 instead of pycodestyle).