Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modelName in external module #2335

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fix modelName in external module #2335

merged 1 commit into from
Mar 14, 2022

Conversation

med-ayssar
Copy link
Contributor

@med-ayssar med-ayssar commented Mar 9, 2022 •
edited
Loading

Fixes #2255

@clinssen clinssen requested review from jougs and clinssen March 11, 2022 08:33
@clinssen clinssen added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 11, 2022
jougs
jougs approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks!

@clinssen
Copy link
Contributor

Awesome, many thanks!

@clinssen clinssen merged commit 4d62daa into nest:master Mar 14, 2022
@clinssen clinssen mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clinssen clinssen clinssen approved these changes

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing model name in NodeCollection
3 participants
@med-ayssar @clinssen @jougs