-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Parameter
objects for indegree
and outdegree
in syn_spec
s
#2501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think that one now can pass a Parameter
object as indegree/outdegree should be documented. I guess doc/htmldoc/synapses/connection_management.rst would be a good place for the documentation, but there might be another more suitable location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I only have a minor grammatical suggestion, otherwise I approve once all tests pass
Co-authored-by: Nicolai Haug <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you very much for this useful addition! 👍
Parameter
object for indegree and outdegreeParameter
objects for indegree
and outdegree
in syn_spec
s
Attempts to fix #1615 by implementing the possibility to pass a
Parameter
object as indegree infixed_indegree
or as outdegree infixed_outdegree
.Example: