Set sender node id info with correct target lcid #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanVogelsang
added
ZC: Kernel
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
terhorstd
added
T: Maintenance
|
@JanVogelsang: can you please comment on the status of this (and maybe merge master)? Thanks! |
github-actions
bot
removed
the
stale
|
Well, status is that I am waiting for a review. It's a rather small change and even a non-breaking one, but one that might help reduce errors in the future (as I had a bug in one of my branches because of this). |
JanVogelsang
force-pushed
the
master
branch
2 times, most recently
from
f9efc88
to
e441a55
Compare
jougs
reviewed
Jul 10, 2023
jougs
requested review from
clinssen
and removed request for
heplesser and
abigailm
mlober
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
event_delivery_managerthesender_node_id_infois set during the event delivery using the samelcidfor all contiguous connections with the same source instead of the actual lcid of the connection. This is not wrong per se, but prevents us from grabbing the correct lcid lateron from theset_sender_node_id_info. One could argue if that shouldn't be done at all, but why not. In NEST there is currently no use case in the kernel or any existing model, but it might potentially be used in NESTML or when users write their own models.Setting the correct lcid does not add any overhead and even reduces some redundancy in the code.