Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the package index files on all CI runners #2796

Merged
merged 3 commits into from
May 23, 2023

Conversation

nicolossus
Copy link
Member

According to the GitHub Actions documentation, one should always run sudo apt-get update before installing a package. This PR adds the command to all runners. This seems to fix the installation of Vale, which has been failing recently.

@nicolossus nicolossus added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels May 22, 2023
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolossus thanks for this change, I think we are moving towards the apt only syntax, so I suggest to remove the 'get'

.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
Co-authored-by: jessica-mitchell <[email protected]>
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jessica-mitchell
Copy link
Contributor

I am merging this PR with 1 reviewer since it's a minor change to the CI, and was discussed briefly with @terhorstd offline.

@jessica-mitchell jessica-mitchell merged commit be6176c into nest:master May 23, 2023
@nicolossus nicolossus deleted the fix_ci_vale_install branch May 23, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants