-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hand-written modelsmodule by a code generation framework #2835
Conversation
@JanVogelsang: Voilà! Only nine weeks after I said "this is really easy!" 😇 😅 |
@jessica-mitchell: It seems that all links to the Potjans model of the form |
@jougs, hm they seem to work for me both in this PR and master: I checked the link from models-main pageand the link in the examples index page and both correctly displayed the Microcircuit model docs. |
Are you using a build directory separate from the source directory or are you running |
I was checking the build on Read the docs, but the local build (current master) with a separate build directory also works for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
…IS_FATAL introduced by nest#2835
This replaces the hand-written
modelsmodule.cpp
by a mechanism to generate it dynamically from CMake arguments.I think the documentation I wrote best explains the rationale for this change:
This is the better solution I have promised in #2663.