Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_calcium.py formatting to comply with Black #2837

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix test_calcium.py formatting to comply with Black #2837

merged 1 commit into from
Jun 22, 2023

Conversation

nicolossus
Copy link
Member

@nicolossus nicolossus commented Jun 22, 2023 •
edited
Loading

Somehow #2627 was able to merge without having Black compliant formatting and the CI in master now fails. This PR fixes the formatting and thus the CI. This should be merged ASAP as the CI now also fails for branches with PRs toward master.

@nicolossus nicolossus added T: Bug Wrong statements in the code or documentation S: Critical Needs to be addressed immediately I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 22, 2023
terhorstd
terhorstd approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all no-op changes. LGTM. The passing build for the #2627 needs to be investigated, though.

@terhorstd terhorstd added T: Maintenance Work to keep up the quality of the code and documentation. and removed T: Bug Wrong statements in the code or documentation labels Jun 22, 2023
@terhorstd terhorstd modified the milestones: NEST 3.4, NEST 3.5 Jun 22, 2023
jougs
jougs approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching and fixing

@jougs jougs merged commit be9b573 into nest:master Jun 22, 2023
@nicolossus
Copy link
Member Author

These are all no-op changes. LGTM. The passing build for the #2627 needs to be investigated, though.

@terhorstd @jougs I took a closer look at the build for #2627 and the reason it passed was that it still used the black_IGNORED checker, which passed even though the formatting not was Black compliant. The Black checker was changed to fail for non-compliant code with #2750.

Since #2750 was recently merged, we should ensure other current PRs pull master with the correct CI pipeline when reviewing.

@nicolossus nicolossus deleted the fix_test_calcium_black branch June 22, 2023 13:42
@nicolossus nicolossus mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

@jougs jougs jougs approved these changes

@heplesser heplesser Awaiting requested review from heplesser

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Critical Needs to be addressed immediately T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
NEST 3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolossus @jougs @terhorstd