Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate notebook and all references to it. #2855

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Remove duplicate notebook and all references to it. #2855

merged 1 commit into from
Jul 10, 2023

Conversation

heplesser
Copy link
Contributor

In model_details, IAF_neurons_singularity was an outdated version of IAF_Integration_Singularity. This PR removes it and changes all references to the newer notebook.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jul 7, 2023
jessica-mitchell
jessica-mitchell approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @heplesser lgtm

@jessica-mitchell
Copy link
Contributor

Merging with 1 reviewer as its documentation

@jessica-mitchell jessica-mitchell merged commit cebe42c into nest:master Jul 10, 2023
@heplesser heplesser deleted the remove_superseeded_notebook branch September 15, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heplesser @jessica-mitchell