Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to set mpi address via device status #2858

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Add support to set mpi address via device status #2858

merged 3 commits into from
Jul 12, 2023

Conversation

marcelkrueger
Copy link
Contributor

This is the refactored approach of the MPI address discussed in #2585.

The mpi address can be set via the device status.
E.g.:

nest.SetStatus(sr,{"record_to":"mpi","mpi_address":"ADDRESS"})

@marcelkrueger @mfahdaz @sontheimer
Add support to set mpi address via device status
a9cf91a 
Co-authored-by: Muhammad Fahad Azeemi <[email protected]>
Co-authored-by: Kim Sontheimer <[email protected]>
@marcelkrueger marcelkrueger mentioned this pull request Jul 12, 2023
Closed
@jougs jougs self-requested a review July 12, 2023 12:07
@jougs jougs added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jul 12, 2023
jougs
jougs requested changes Jul 12, 2023
View reviewed changes
nestkernel/recording_backend_mpi.cpp Outdated Show resolved Hide resolved
nestkernel/recording_backend_mpi.cpp Outdated Show resolved Hide resolved
nestkernel/recording_backend_mpi.cpp Outdated Show resolved Hide resolved
nestkernel/recording_backend_mpi.cpp Outdated Show resolved Hide resolved
nestkernel/recording_backend_mpi.h Outdated Show resolved Hide resolved
nestkernel/stimulation_backend_mpi.cpp Outdated Show resolved Hide resolved
nestkernel/stimulation_backend_mpi.cpp Outdated Show resolved Hide resolved
nestkernel/stimulation_backend_mpi.cpp Outdated Show resolved Hide resolved
nestkernel/stimulation_backend_mpi.h Outdated Show resolved Hide resolved
nestkernel/stimulation_backend_mpi.h Outdated Show resolved Hide resolved
jougs
jougs approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this nice contribution.

@jougs
Copy link
Contributor

jougs commented Jul 12, 2023

@sontheimer: could you maybe quickly indicate your approval as a potential consumer of this new feature? Thanks!

sontheimer
sontheimer approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@sontheimer sontheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes were tested locally with a NEST-TVB cosimulation. Works as intended, approved.

@jougs jougs merged commit 9cb3cb2 into nest:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sontheimer sontheimer sontheimer approved these changes

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelkrueger @jougs @sontheimer