Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup NEST Server environment variable handling #2942

Merged
merged 126 commits into from
Sep 20, 2023
Merged

Cleanup NEST Server environment variable handling #2942

merged 126 commits into from
Sep 20, 2023

Conversation

babsey
Copy link
Contributor

@babsey babsey commented Sep 14, 2023

It bootstraps NEST Server with new environment variables and comparison with random string.

babsey and others added 30 commits July 19, 2023 11:23
@babsey
Add env EXEC_SCRIPT
678b0ec
@babsey
Cleanup nest-server
50ffba0
@babsey
Add changes for v3.4
1b2f5a1
@babsey
Set Origins in CORS
bb72edc
@babsey
Add cross origin for /
886ee90
@babsey
Extend cors_origins
9f40046
@Helveg @babsey
Display Python logging, even while server is active.
00eb651
@Helveg @babsey
Apply CORS headers
6a5591b
@Helveg @babsey
forgot 1
d6f87f8
@Helveg @babsey
Vanishing application and authentication :)
ab2e525
@Helveg @babsey
Allowed authentication to be disabled.
b8417b8
@Helveg @babsey
restored nest import
a0c7774
@Helveg @babsey
Improved comments
ba35053
@Helveg @babsey
reverted more things I did to test locally.
d6d013f
@Helveg @babsey
moved handler for pep8, use bool util
1d27bc9
@Helveg @babsey
pep8 fixes
11ea078
@Helveg @babsey
abort --> flask.abort
0445157
@Helveg @babsey
fixed unauthorized error when no auth header is given
b510def
@babsey
Add env EXEC_SCRIPT
352f65c
@babsey
Cleanup nest-server
cb7a4ab
@babsey
Add changes for v3.4
8fdffd6
@babsey
Set Origins in CORS
740bc8f
@babsey
Add cross origin for /
f9d0b56
@babsey
Extend cors_origins
b29c2b2
@Helveg @babsey
Apply CORS headers
31c0951
@Helveg @babsey
forgot 1
c7f09ab
@Helveg @babsey
Vanishing application and authentication :)
84e8224
@Helveg @babsey
Allowed authentication to be disabled.
21b408f
@Helveg @babsey
restored nest import
3abc6a9
@Helveg @babsey
Improved comments
9bf1ac5
@babsey
Merge pull request #6 from jessica-mitchell/nest-server-cleanup
18fa050 
Move text to NEST Server guide and link from whats new
@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Sep 15, 2023
@terhorstd terhorstd added this to the 3.6 milestone Sep 19, 2023
@terhorstd terhorstd added S: High Should be handled next and removed S: Normal Handle this with default priority labels Sep 19, 2023
terhorstd
terhorstd approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now, and I'd accept. It's not full blown and more could be done, but it's clean and does the job for now.

Thanks for the fast round-trip times! 👍

@jessica-mitchell jessica-mitchell mentioned this pull request Sep 19, 2023
Merged
jougs
jougs requested changes Sep 19, 2023
View reviewed changes
pynest/nest/server/hl_api_server.py Outdated Show resolved Hide resolved
pynest/nest/server/hl_api_server.py Outdated Show resolved Hide resolved
pynest/nest/server/hl_api_server.py Outdated Show resolved Hide resolved
pynest/nest/server/hl_api_server.py Outdated Show resolved Hide resolved
doc/htmldoc/connect_nest/nest_server.rst Outdated Show resolved Hide resolved
babsey and others added 2 commits September 20, 2023 11:45
@babsey
Copy link
Contributor Author

babsey commented Sep 20, 2023

It has to be corrected in @jougs suggestion. I am working on this.

babsey
babsey commented Sep 20, 2023
View reviewed changes
Copy link
Contributor Author

@babsey babsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small inline suggestions

doc/htmldoc/connect_nest/nest_server.rst Outdated Show resolved Hide resolved
doc/htmldoc/connect_nest/nest_server.rst Outdated Show resolved Hide resolved
doc/htmldoc/connect_nest/nest_server.rst Outdated Show resolved Hide resolved
@terhorstd
Copy link
Contributor

Thanks for the quick rounds of fixes. I'll merge as soon as all static checks have passed and then move on the the final one for 3.6 😉

@terhorstd terhorstd merged commit f6e004e into nest:master Sep 20, 2023
21 checks passed
@babsey babsey deleted the nest-server-cleanup branch September 20, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
S: High Should be handled next T: Enhancement New functionality, model or documentation
Projects
Installation
Status: Done
Milestone
NEST 3.6
Development

Successfully merging this pull request may close these issues.
5 participants
@babsey @terhorstd @jougs @jessica-mitchell @Helveg