Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in reconstruction of connection data structures after disconnect and fix small problems with examples #2948

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

heplesser
Copy link
Contributor

This PR contains two parts:

  • A critical bug fix including new test to ensure connection data structures are properly rebuilt after disconnect.
  • Fixes to some examples and the example runner to ensure they work with current master.

This PR changes the order of structural plasticity and spike delivery: When using compressed spikes, we can only deliver spikes through the same connection setup in which they were gathered.

@terhorstd @jougs I label this one as critical because it must make it into 3.6.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: Critical Needs to be addressed immediately I: Behavior changes Introduces changes that produce different results for some users labels Sep 18, 2023
@terhorstd terhorstd added this to the 3.6 milestone Sep 19, 2023
Copy link
Contributor

@jhnnsnk jhnnsnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I have run a structural plasticity example and it gives the same result as with NEST 3.5. The test also works.
I am just wondering if in the simulation_manager.cpp the #pragma's are needed because if I try to run with multiple threads I get the error:
nest.lib.hl_api_exceptions.Structural plasticity can not be used with multiple threads: Structural plasticity can not be used with multiple threads in SLI function EnableStructuralPlasticity: . But this goes beyond the specific changes of this PR.

@heplesser heplesser merged commit a2e2287 into nest:master Sep 19, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: Behavior changes Introduces changes that produce different results for some users S: Critical Needs to be addressed immediately T: Bug Wrong statements in the code or documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants