Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align documentation of connection management with connectivity concepts publication #2992

Merged
merged 39 commits into from
Apr 5, 2024

Conversation

clemensk0
Copy link
Contributor

This pull request revises the documentation of the connection management based on the connectivity concepts publication Senk et al. (2022): https://doi.org/10.1371/journal.pcbi.1010086
There will be a follow up pull request to the NEST Desktop documentation for the graphical notation introduced in the same publication.
As discussed in the open NEST Developer Conference this documentation shall be a living document. The documentation on network connectivity in NEST now contains Connection management, Synapse specification and How to handle created connections. With this pull request we only focused on the connectivity management and only marginally updated the content of the other pages.

Further improvements:

  • How to improve the caption of the overview of connections patterns on top of the page?
  • How to highlight deviations from the public connectivity concept in the article?

As reviewers we suggest @heplesser @jessica-mitchell @albada

I prepared this pull request together with @jhnnsnk

@jhnnsnk
Copy link
Contributor

jhnnsnk commented Nov 16, 2023

Adjustement is needed when #2955 (tripartite connection rule) is merged.


.. admonition:: Availability
This documentation not only describes how to define network connectivity in NEST, but also represents a living reference for the connection rules defined in the article "Connectivity concepts in neuronal network modeling" [1]_. Deviations from the rules defined in the publication are highlighted in green.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heplesser Shall we add a statement suggesting that the paper could be cited as a permanent reference for a certain rule?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that seems like a good idea!

@heplesser heplesser added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Nov 17, 2023
Comment on lines 3 to 4
How to handle created connections
=================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
How to handle created connections
=================================
How to inspect and modify connections
==============================

Also in the text below, "already created" sounds strange. Either write "existing connections" or just "connections", because when you talk about inspecting and modifying, that implies that the connections must exist.

=================================

Here, we describe how to inspect and modify already created connections.
For creating new connections, refer to :ref:`connection_management`, and for parameterizing synapses, see :ref:`synapse_spec`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameterization you mean here is the one during creation, isn't it? Then the sentence is confusing. Maybe something like

Suggested change
For creating new connections, refer to :ref:`connection_management`, and for parameterizing synapses, see :ref:`synapse_spec`.
:ref:`connection_management` describes how to create new connections and :ref:`synapse_spec` how to parameterize synapses as they are created.

@jessica-mitchell
Copy link
Contributor

@heplesser To inspect the build of the documentation, we need the workflow to run, can we approve and run?

@heplesser
Copy link
Contributor

@heplesser To inspect the build of the documentation, we need the workflow to run, can we approve and run?

Done!

@jessica-mitchell
Copy link
Contributor

@clemensk0 just fyi, I tried to fix a small typo in the hopes that the commit would trigger the Read the docs build. There's seems to be an issue with it atm, which I'm looking into.

Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clemensk0 and @jhnnsnk for your contribution to the docs, it's a nice improvement! I have one more PR against @clemensk0 branch to fix some links but I approve this PR

@jessica-mitchell
Copy link
Contributor

@clemensk0 can you resolve the conflicts? @jhnnsnk

@heplesser
Copy link
Contributor

heplesser commented Mar 1, 2024

@clemensk0 Ping! It would also be a good idea to merge NEST master into your branch for this PR.

@jessica-mitchell jessica-mitchell merged commit 8f8b184 into nest:master Apr 5, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants