-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for iaf_psc_exp
#3084
Conversation
iaf_psc_exp
iaf_psc_exp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ackurth This looks quite good already, but see my inline comments. I would also like to ask for a slight re-ordering of material that you have not touched:
- Move the last paragraph before the Parameters section ("For conversion ...") before the note on the time constants.
- Put the material on the two different ways in which the model can handle input into a note as well.
Here is link to output on Read the Docs: https://nest-simulator--3084.org.readthedocs.build/en/3084/models/iaf_psc_exp.html |
@ackurth @heplesser After some discussion with David D. about models, we noticed that in the original model description, it mentions the stochastic use case - which does not appear to be in this version - is that correct?
|
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
… into iaf_psc_model_doc
Co-authored-by: jasperalbers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ackurth, just a couple of minor typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ackurth Thanks, this is fine now except for the small details @jessica-mitchell has pointed out. Please merge master so that tests will pass.
Co-authored-by: jessica-mitchell <[email protected]>
Co-authored-by: jessica-mitchell <[email protected]>
No description provided.