Fix broken links in documentation #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessica-mitchell
added
S: Normal
heplesser
requested changes
Mar 1, 2024
There was a problem hiding this comment.
@jessica-mitchell Thanks for sorting this out! I provide proper references for the AEIF notebook and suggestions for hh_... in my comments below.
heplesser
approved these changes
Mar 4, 2024
|
Merging with 1 reviewer as its minor documentation related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some links that were broken.
A few other broken links were found that I could not find a working link to point to.
Namely these in aeif implementation notebook:
There was a broken modeldb link for
models/hh_cond_beta_gap_traub.h.I don't know what it was supposed to link to since there is not citation in the text. If I put in the same number to the new modeldb site, I get the following result https://modeldb.science/83319?tab=1. Does it make sense to have this link in this model?