Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localhost ipv4 to default origins for NEST Server #3151

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Add localhost ipv4 to default origins for NEST Server #3151

merged 1 commit into from
Mar 13, 2024

Conversation

babsey
Copy link
Contributor

@babsey babsey commented Mar 13, 2024 •
edited
Loading

NEST Desktop starts on the IP of localhost (127.0.0.1) by default.
From there, NEST Server returns Error Code 304 - no permission.

This fix solves this issue.

@babsey babsey requested a review from terhorstd March 13, 2024 14:26
terhorstd
terhorstd approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@terhorstd terhorstd changed the title Add 127.0.0.1 to default origins Add localhost ipv4 to default origins for NEST Server Mar 13, 2024
@terhorstd terhorstd added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 13, 2024
@terhorstd terhorstd merged commit 2712786 into nest:master Mar 13, 2024
24 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
@babsey babsey deleted the nest-server-default-origins branch July 18, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Bug Wrong statements in the code or documentation
Projects
Installation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babsey @terhorstd