Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change numpy datatype to adapt to NumPy 2.0 #3226

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

heplesser
Copy link
Contributor

This PR fixes #3224.

Labeling this as critcial because all PR runs will fail until this is fixed.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: Critical Needs to be addressed immediately I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 17, 2024
pynest/pynestkernel.pyx Outdated Show resolved Hide resolved
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and cleanup
👍

@heplesser heplesser merged commit 66da345 into nest:master Jun 19, 2024
24 checks passed
@terhorstd terhorstd added S: High Should be handled next and removed S: Critical Needs to be addressed immediately labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

NumPy 2.0 breaks some NEST tests
3 participants