Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning concerning order of parameter creation and change in number of threads #3229

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

heplesser
Copy link
Contributor

This PR provides a temporary patch for #3228.

Since this only adds documentation, a single reviewer suffices.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 18, 2024
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good

@heplesser heplesser added this to the NEST 3.8 milestone Jun 20, 2024
@heplesser heplesser merged commit f3b7323 into nest:master Jun 20, 2024
24 checks passed
@jessica-mitchell jessica-mitchell added T: Maintenance Work to keep up the quality of the code and documentation. and removed T: Bug Wrong statements in the code or documentation labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants