Reduce the number of build jobs #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many configuration options of NEST are actually independent. This means we don't have to run the full matrix, but just a minimal job, a maximal job, and some jobs for dependent options. This commit simplifies the matrix from 8 runs to 4 runs while also adding a new option for builds with and without threading.
|
Very nice work. How about having |
|
@jougs As we have discussed about this yesterday, I don't have any further comments from my side. It is great that you could find the 3 failing tests which depends on threading when the matrix job without threads were executed. In short, LGTM |
|
@tammoippen: good idea, I've added these options in the latest commit. |
|
Please don't merge yet! I'll push another commit soon! |
…s instead of Jenkins
|
I've updated the documentation about continuous integration in the last commit. Please let me know if you require additional changes before merging. Many thanks! |
| ## Build jobs | ||
|
|
||
| The CI system is set up to run upon commits to branches that are | ||
| related to a pull request, or for commits that are in a fork, for |
There was a problem hiding this comment.
Remove comma after "fork"
|
👍 from me once the minor language issues are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many configuration options of NEST are actually independent. This means we don't have to run the full matrix, but just a minimal job, a maximal job, and some jobs for dependent options.
This PR simplifies the matrix from 8 runs to 4 runs while also adding a new option for builds with and without threading (04c668b).
Using this, I already found 3 tests that were failing when building without threading (5387bbc).
I suggest @heplesser and @lekshmideepu as reviewers.