Add automatic testing for MUSIC #471

jougs · 2016-09-01T13:57:23Z

This PR adds MUSIC support to the maximal build for Travis CI. It also brings a framework for testing MUSIC enabled SLI scripts to the testsuite. A README explains it's usage, while three basic tests serve as examples of how to write tests for the new framework.

I suggest @heplesser, @mdjurfeldt and @uahic as reviewers.

* The new version also takes the name of the executable to run instead of hard-coding $PREFIX/bin/nest * Adapt the testsuite runner to check for the new version * Adapt the Travis CI build script to not define mpirun by itself, but use the provided version * Adapt the unittest and processes library to correctly call the new version

…tomatic_music_testing

heplesser · 2016-09-04T22:57:00Z

@jougs @mdjurfeldt As a first step, I have tried to build MUSIC under OSX 10.11.6 with gcc 6.2.1 and OpenMPI 2.0.1. I noticed two problems:

In autogen.sh, libtoolize must be glibtoolize on the Mac
When compiling, I get the following error (also with clang):

../../music/src/music/data_map.hh:46:13: error: 'MPI' does not name a type
     virtual MPI::Datatype type () = 0;

In NEST's mpi_manager.cpp I only find MPI_Datatype and similar, not MPI::Datatype. The only place where I spot MPI:: is in mpi_manager.h, and there it seems MUSIC-related.

Could you enlighten me?

mdjurfeldt · 2016-09-04T23:03:49Z

How can one, in autogen.sh, detect that the environment is a mac?

Den 5 sep. 2016 00:57 skrev "Hans Ekkehard Plesser" <
[email protected]>:

@jougs https://github.com/jougs @mdjurfeldt
https://github.com/mdjurfeldt As a first step, I have tried to build
MUSIC under OSX 10.11.6 with gcc 6.2.1 and OpenMPI 2.0.1. I noticed two
problems:

In autogen.sh, libtoolize must be glibtoolize on the Mac

When compiling, I get the following error (also with clang):

../../music/src/music/data_map.hh:46:13: error: 'MPI' does not name a type
virtual MPI::Datatype type () = 0;

In NEST's mpi_manager.cpp I only find MPI_Datatype and similar, not
MPI::Datatype. The only place where I spot MPI:: is in mpi_manager.h, and
there it seems MUSIC-related.

Could you enlighten me?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#471 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADcfCcy9PM0pdZc8l_cpthBA4e000eivks5qm0y9gaJpZM4JyuGG
.

heplesser · 2016-09-04T23:10:31Z

This is from nest-2.10.0's bootstrap.sh:

if [ `uname -s` = Darwin ] ; then
# libtoolize is glibtoolize on OSX
  LIBTOOLIZE=glibtoolize
else  
  LIBTOOLIZE=libtoolize
fi

mdjurfeldt · 2016-09-05T08:59:48Z

i'm sorry---Tammo has already submitted a pull request to MUSIC (INCF/MUSIC#24) fixing this. The reason why it has stalled is that I need to think about a name collision for a script. I'll do this.

MPI:: is the name space for the C++ interface. I will install openmpi 2.0 myself and examine this issue. (The C++ interface has been deprecated since version 2.2. of the MPI standard.)

jougs · 2016-09-05T09:33:57Z

@heplesser, @mdjurfeldt: can you please move the discussion about problems in MUSIC to a corresponding issue on https://github.com/INCF/MUSIC and reference that here? It is rather confusing to have this discussion here. Thanks!

heplesser · 2016-09-14T12:46:34Z

lib/sli/processes.sli

- % return value is return value of command
-}
-def
-


@jougs Why are you removing this? It may be perfectly sensible, I just would like to know.

My reasoning for the removal was like this: the check for /mpirun is not needed anymore, now that we always provide a not-commented version of /mpirun in .nestrc. The remaining code does not add anything above what /mpirun and /nest_indirect already provide.

heplesser · 2016-09-14T14:08:41Z

testsuite/musictests/test_event_proxies_receiver.sli

@@ -32,7 +32,7 @@ meip << /port_name (spikes_in) /music_channel 0 >> SetStatus
 meip n << /weight 750.0 >> Connect


This comment applies to the MPI-check a little further up. Could you replace the explicit quit_i code with an exit_test_gracefully (or what it is called exactly)?

heplesser · 2016-09-14T14:15:02Z

@jougs This looks pretty good to me, but see my comments in the code.

Would it make sense to add at least one test in which the individual SLI processes have more than one MPI process each?

I am a little uncertain if I like the idea of files just being grouped into tests by equal/similar names. Would it make sense to have one directory per test to make the grouping explicit? I am mainly concerned with what will happen if we apply this framework to mpi-based testing in general with a large number of tests.

…esting

jougs · 2016-09-14T15:47:50Z

@heplesser: thanks for the review. I've addressed all of your comments in the recent commits. Moreover, I have made the error message for an old version of /mpirun more explicit with respect to custom versions of the function.

We should definitely add more tests for MUSIC, also including some using more than one process per application. However, this PR is merely about adding the framework and basic tests to show how things work. It was not meant to add extensive testing for MUSIC. Feel free to add an issue for any missing test case you think should be covered.

I also thought about putting the files in subdirectories, but refrained from doing so, as this would IMO limit discoverability of the existing tests. That said, I am open to re-discuss this once we extend the framework to other test phases.

gtrensch · 2016-09-15T10:25:12Z

examples/sli/nestrc.sli

-%} Function def
+
+% The command mpirun tells NEST how to assemble a string, which
+% represents a valid command for calling a MPI-enabled executable in a


an MPI-enabled

gtrensch · 2016-09-15T10:27:12Z

👍 reviewed and tested. Check for old version of the /mpirun command works also fine now !

heplesser

@jougs All fine, and I approve!

jougs added 19 commits August 18, 2016 03:08

Add MUSIC to the maximal job on Travis CI

2653c14

Remove old version of mpirun, aka mpirun_call

fd74e99

Clean up NEST configuration file

d4a06e5

Fix copyright header

e856e7d

Add MUSIC tests to the test setup

ea7f473

Move minimal music exampe to testsuite

3ffd9a9

Added most parts of the unittest framework for MUSIC tests

3d0c11d

SLI scripts now write to files are compared

e774ca1

Add test that intentionally fails due to missing second process

76d6694

Add test that intentionally fails due to missing argument files

185835d

Merge branch 'master' of git://github.com/nest/nest-simulator into au…

5538eaa

…tomatic_music_testing

Added mpi4py to TravisCI installation

ed792c0

Copy the nestrc file to the home directory

861e1cd

Changed name of the README file to README.md

7df0a40

Rename minimalmusicsetup to test_event_proxies

a9fd98f

Added README.md for musictests and adapted general testsuite README.md

399f72b

Fix phase number

86a9a28

Added new line at end of file

a2bd24a

gtrensch mentioned this pull request Sep 8, 2016

Music cont out proxy #280

Closed

jougs changed the title ~~Add automatic testing for MUSIC~~ Add automatic testing for MUSIC 👍 Sep 12, 2016

jougs changed the title ~~Add automatic testing for MUSIC 👍~~ Add automatic testing for MUSIC Sep 12, 2016

heplesser reviewed Sep 14, 2016
View reviewed changes

jougs added 4 commits September 14, 2016 17:34

Move check for old definition of /mpirun to the beginning

41a798d

Fix wording

653ab9e

Replace explicit quitting by call to exit_test_gracefully

d97b03e

Merge remote-tracking branch 'upstream/master' into automatic_music_t…

5475c08

…esting

gtrensch reviewed Sep 15, 2016

View reviewed changes

Fix article

41bfbfd

heplesser approved these changes Sep 16, 2016

View reviewed changes

heplesser merged commit 38a9608 into nest:master Sep 16, 2016

heplesser mentioned this pull request Sep 27, 2016

Proposed fix for issue #463 #465

Merged

jougs mentioned this pull request Jun 29, 2017

Write tests for the MUSIC interface #347

Closed

jougs deleted the automatic_music_testing branch November 25, 2022 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add automatic testing for MUSIC #471

Add automatic testing for MUSIC #471

jougs commented Sep 1, 2016

heplesser commented Sep 4, 2016

mdjurfeldt commented Sep 4, 2016

heplesser commented Sep 4, 2016

mdjurfeldt commented Sep 5, 2016 •

edited by jougs

Loading

jougs commented Sep 5, 2016

heplesser Sep 14, 2016

jougs Sep 14, 2016

heplesser Sep 14, 2016

heplesser commented Sep 14, 2016

jougs commented Sep 14, 2016

gtrensch Sep 15, 2016

gtrensch commented Sep 15, 2016

heplesser left a comment

		@@ -32,7 +32,7 @@ meip << /port_name (spikes_in) /music_channel 0 >> SetStatus
		meip n << /weight 750.0 >> Connect

Add automatic testing for MUSIC #471

Add automatic testing for MUSIC #471

Conversation

jougs commented Sep 1, 2016

heplesser commented Sep 4, 2016

mdjurfeldt commented Sep 4, 2016

heplesser commented Sep 4, 2016

mdjurfeldt commented Sep 5, 2016 • edited by jougs Loading

jougs commented Sep 5, 2016

heplesser Sep 14, 2016

Choose a reason for hiding this comment

jougs Sep 14, 2016

Choose a reason for hiding this comment

heplesser Sep 14, 2016

Choose a reason for hiding this comment

heplesser commented Sep 14, 2016

jougs commented Sep 14, 2016

gtrensch Sep 15, 2016

Choose a reason for hiding this comment

gtrensch commented Sep 15, 2016

heplesser left a comment

Choose a reason for hiding this comment

mdjurfeldt commented Sep 5, 2016 •

edited by jougs

Loading