Fix for #406 (ascii issue) #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hakonsbm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @otizonaizit, @apeyser and @jougs to be potential reviewers. |
|
@hakonsbm: can you please remove the trailing whitespace in pynest/pynestkernel.pyx? Thanks! |
heplesser
added
ZC: PyNEST
|
@apeyser Could you have a look at this one and see if it is ready for a second thumb up? |
|
I'd suggest wrapping up just to remove the repeated ifs scattered through the code. |
|
@apeyser Something like this? |
apeyser
approved these changes
Nov 25, 2016
|
|
||
| def decode(s): return s.decode('utf-8') | ||
| def decode(s): | ||
| return s.decode('utf-8') |
| @@ -82,19 +82,21 @@ def catching_sli_run(cmd): | |||
| """ | |||
|
|
|||
| if sys.version_info >= (3,): | |||
| engine.run('{%s} runprotected' % cmd) # Python 3 | |||
| def encode(s): return s | |||
There was a problem hiding this comment.
Precisely like this. The rest of the code is simplified and clear.
|
@apeyser Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyNEST will now raise a
NESTErrorwhen trying to use non-ascii characters under Python 2.7.We did not manage to find a way to make PyNEST work with non-ascii characters under Python 2.7. Note that this works under Python 3.