Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for compiler warnings and spelling #729

Merged
merged 2 commits into from
May 29, 2017
Merged

Small fixes for compiler warnings and spelling #729

merged 2 commits into from
May 29, 2017

Conversation

heplesser
Copy link
Contributor

This PR fixes two minor details in C++-code eliciting compiler warnings at least with clang and fixes a few spelling errors in messages and documentation.

@heplesser heplesser added ZC: Model DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels May 22, 2017
stinebuu
stinebuu approved these changes May 23, 2017
View reviewed changes
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me!

@heplesser heplesser mentioned this pull request May 24, 2017
Merged
tammoippen
tammoippen approved these changes May 29, 2017
View reviewed changes
Copy link
Contributor

@tammoippen tammoippen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@heplesser heplesser merged commit 97e172a into nest:master May 29, 2017
@heplesser heplesser deleted the small-cpp-fixes branch May 31, 2017 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinebuu stinebuu stinebuu approved these changes

@tammoippen tammoippen tammoippen approved these changes

@gtrensch gtrensch Awaiting requested review from gtrensch

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Model DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heplesser @tammoippen @stinebuu