Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example script for structural plasticity #753

Merged
merged 3 commits into from
Aug 11, 2017
Merged

Add example script for structural plasticity #753

merged 3 commits into from
Aug 11, 2017

Conversation

jakobj
Copy link
Contributor

@jakobj jakobj commented Jun 14, 2017 •
edited
Loading

Since I've just translated a benchmark script for structural plasticity from PyNEST to sli, I thought it would make sense to integrate this into the codebase to make it available to everyone. The idea is to provide a script that allows for reasonable benchmarking of structural plasticity performance, similar as the hpc_benchmark.sli does for standard plasticity.

I would like to hear @sdiazpier opinion on whether this translation looks reasonable and @mschmidt87 sli-benchmark-experienced opinion on whether I messed something up that would cause a significant slowdown. Maybe @suku248 or @heplesser could also have a look regarding best practices of SLI use.

@heplesser heplesser requested a review from sdiazpier June 29, 2017 12:17
@heplesser heplesser added ZC: Documentation DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Jun 29, 2017
@heplesser heplesser added this to the NEST 2.12.1 milestone Jun 29, 2017
@sdiazpier
Copy link
Contributor

Hi dear @jakobj, great job! As far as I can see, all the elements regarding structural plasticity are ok and the translation looks reasonable. 👍

sdiazpier
sdiazpier approved these changes Jul 24, 2017
View reviewed changes
Copy link
Contributor

@sdiazpier sdiazpier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benchmark is a translation of the pynest example which considers most of the relevant effects of the implementation of structural plasticity in NEST.

@heplesser heplesser requested a review from suku248 July 31, 2017 12:09
suku248
suku248 approved these changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@suku248 suku248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakobj ! I don't find any obvious errors.

@heplesser heplesser merged commit 7d6a0bf into nest:master Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdiazpier sdiazpier sdiazpier approved these changes

@suku248 suku248 suku248 approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation ZC: Documentation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 2.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jakobj @sdiazpier @suku248 @heplesser