Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute path for compile-time NEST_PREFIX (cf. #749) #796

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Use absolute path for compile-time NEST_PREFIX (cf. #749) #796

merged 1 commit into from
Aug 3, 2017

Conversation

muffgaga
Copy link
Contributor

@muffgaga muffgaga commented Aug 2, 2017

cf. #783 — PR is now based on a topic branch.

@muffgaga muffgaga mentioned this pull request Aug 2, 2017
Closed
@heplesser heplesser added ZC: Installation DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Aug 2, 2017
jougs
jougs approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue. Approving and merging.

@jougs jougs merged commit d3f2dcd into nest:master Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtrensch gtrensch gtrensch approved these changes

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation ZC: Installation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muffgaga @jougs @gtrensch @heplesser