Remove binary_neuron_impl.h #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the _impl.h file provides required definitions of template functions, it always needs to be included along with the .h file. To avoid having two seperate files for the definition of the binary_neuron template, all functions are moved to the .h file.
jakobj
force-pushed
the
fix/remove_binary_neuron_impl
branch
from
f940cd7
to
e580b59
Compare
heplesser
added
ZC: Model
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the _impl.h file provides required definitions of template functions, it always needs to be included along with the .h file. To avoid having two seperate files for the definition of the binary_neuron template, all functions are moved to the .h file.
This followed from the discussion in #492, I suggest @heplesser and @jougs as reviewers.