Aeif psc delta 2 continued #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace expensive division with multiplication
…aeif_psc_delta2 Name change in remote caused conflict
set/getable. Reordered position of with_refr_input_ in aeif_psc_delta.h to avoid warning.
Closed
heplesser
approved these changes
Nov 6, 2017
Silmathoron
reviewed
Nov 7, 2017
|
|
||
| # Compare models to the LSODAR implementation. | ||
|
|
||
| def test_closeness_nest_lsodar(self): |
There was a problem hiding this comment.
this was changed by @gtrensch is it okay to switch back to docstrings now?
| aeif_DT0_delta = aeif_DT0.copy() | ||
| aeif_DT0_delta.pop('tau_syn_ex') | ||
|
|
||
| DT0_params = {"aeif_cond_alpha": aeif_DT0, |
terhorstd
added
ZC: Model
|
Sorry I took so long to address your comments, @Silmathoron! |
Silmathoron
approved these changes
Nov 27, 2017
There was a problem hiding this comment.
Ok 👍
(the question of the docstrings was to be answered by @gtrensch but I guess this is fine ^^)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #613, and can replace that PR. Most of the work has been reviewed, the difference is that
with_refr_input_is defaulted tofalseand is made set/getable as requested. I have also reordered the placement ofwith_refr_input_inaeif_psc_delta.hto get rid of a warning.Almost all the work is done @lepmik.