Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made path construction os-independent. #902

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Made path construction os-independent. #902

merged 1 commit into from
Mar 8, 2018

Conversation

heplesser
Copy link
Contributor

No description provided.

@heplesser heplesser added ZC: PyNEST DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 7, 2018
@heplesser heplesser added this to the NEST 2.16 milestone Mar 7, 2018
jougs
jougs approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

terhorstd
terhorstd approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.path.join is the right way to go here.

@heplesser heplesser merged commit 678d934 into nest:master Mar 8, 2018
@heplesser heplesser deleted the fix_path_construction branch March 8, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terhorstd terhorstd terhorstd approved these changes

@jougs jougs jougs approved these changes

@weidel-p weidel-p Awaiting requested review from weidel-p

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: PyNEST DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 2.16
Development

Successfully merging this pull request may close these issues.
3 participants
@heplesser @jougs @terhorstd