Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check target #906

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Remove check target #906

merged 2 commits into from
Mar 13, 2018

Conversation

heplesser
Copy link
Contributor

This PR removes the check target for now, because its existence easily misleads users (see recent discussion on NEST User mailing list).

@heplesser heplesser added ZC: Installation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 8, 2018
@heplesser heplesser added this to the NEST 2.16 milestone Mar 8, 2018
@jougs jougs requested review from jougs and removed request for tammoippen March 13, 2018 10:17
jougs
jougs approved these changes Mar 13, 2018
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. I'll merge without second review, as this is a minor change that seems to prevent problems easily without the potential to break anything.

@jougs jougs merged commit d3d8630 into nest:master Mar 13, 2018
@heplesser heplesser deleted the remove-check-target branch April 5, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@terhorstd terhorstd Awaiting requested review from terhorstd

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Installation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 2.16
Development

Successfully merging this pull request may close these issues.
2 participants
@heplesser @jougs