Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typing-extensions version to be compatible with Pydantic #225

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

ketphan02
Copy link
Contributor

@ketphan02 ketphan02 commented Jun 27, 2024

The dependency of typing-extensions has prevented a few people from using the project alongside Pydantic. From v2.0 (Release on 2023-06-30), Pydantic requires typing-extensions>=4.6.1 (reference).

This PR only aims to match the 4.6.1 requirement of Pydantic.

Partially solve #211


Thanks for contributing to Nesta's Skills Extractor Library 🙏!

If you have suggested changes to code anywhere outside of the ExtractSkills class, please consult the checklist below.

Checklist ✔️🐍:

  • I have refactored my code out from notebooks/
  • I have checked the code runs
  • I have tested the code
  • I have run pre-commit and addressed any issues not automatically fixed
  • I have merged any new changes from dev
  • I have documented the code
    • Major functions have docstrings
    • Appropriate information has been added to READMEs
  • I have explained the feature in this PR or (better) in output/reports/
  • I have requested a code review

If you have suggested changes to documentation (and/or the ExtractSkills class), please ALSO consult the checklist below.

Documentation Checklist ✔️📚:

  • I have run make html in docs
  • I have manually reviewed the docs/build/*.html files locally to ensure they have formatted correctly
  • I have pushed both relevant files AND their corresponding docs/build/*.html files

@ketphan02
Copy link
Contributor Author

@lizgzil Can you please take a look at this one? Thank you!

@lizgzil
Copy link
Collaborator

lizgzil commented Jul 1, 2024

thanks for this @ketphan02 ! I will approve. This huge refactor is on the horizon - in which we have pydantic = "^2.7.1" so I hope this won't be an issue for that. Do let me know if you think otherwise?

@lizgzil lizgzil merged commit 06edb14 into nestauk:dev Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants