Skip to content
This repository has been archived by the owner on Feb 7, 2021. It is now read-only.

Feature: Put plumbing in for config to be passed in forRoot #18

Closed
wesleygrimes opened this issue Aug 7, 2019 · 4 comments
Closed

Feature: Put plumbing in for config to be passed in forRoot #18

wesleygrimes opened this issue Aug 7, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@wesleygrimes
Copy link
Member

No description provided.

@wesleygrimes
Copy link
Member Author

wesleygrimes commented Aug 17, 2019 •
edited
Loading

We have several other features pending this issue getting resolved.

Open to PRs to help get this implemented.

@cmwhited @jordanpowell88 was any progress made on this?

@wesleygrimes wesleygrimes mentioned this issue Aug 17, 2019
Closed
@cmwhited
Copy link
Contributor

@wesleygrimes, i should have time here soon to get some work on this. even if it just the basic plumbing.

@wesleygrimes
Copy link
Member Author

That’s great news! Let me know if I can assist in anyway. Once we get the plumbing in for this a lot of features can start flowing. No pun intended 😂🤣

@wescopeland wescopeland mentioned this issue Aug 18, 2019
Merged
@wesleygrimes wesleygrimes added the enhancement New feature or request label Aug 18, 2019
wesleygrimes pushed a commit that referenced this issue Aug 18, 2019
@wescopeland @wesleygrimes
feat: implement configuration via forRoot (#21)
8904c00 
Adds the ability to provide configuration to the InMemoryDBModule via `forRoot` static method.

Implements #18
@wesleygrimes
Copy link
Member Author

Hey @cmwhited, @wescopeland had time to get this going for us. It's basic via forRoot but it's a great start. Looking forward to your feedback on the forFeature implementation down the road.

Thanks everyone for helping out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wesleygrimes @cmwhited