Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): fix case of generated method return and parameter types #3154

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

domusofsail
Copy link

In the generated typescript (schema-first), classes and interfaces for types are upper cased, but remained in the original case when referenced in method arguments and return types.
This is a fix for this.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #3147

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

In the generated typescript (schema-first), classes and interfaces for
types are upper cased, but remained in the original case when
referenced in method arguments and return types.
This is a fix for this.
@kamilmysliwiec kamilmysliwiec merged commit 74c16f7 into nestjs:master Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants