Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assets copying #2553

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

CustomEntity
Copy link
Contributor

@CustomEntity CustomEntity commented Mar 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

I checked the Test checkbox because I couldn't find a way to test for it.

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This pull request addresses the issues encountered with the Nest CLI assets property on Windows platforms (#2397 and #2429), specifically related to the path format causing file copying to fail. The modifications ensure compatibility across different operating systems and correct the handling of Windows path formats.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Fix issue where Nest CLI fails to copy assets files on Windows due to path format
Refactoring few mistakes
@CustomEntity
Copy link
Contributor Author

@kamilmysliwiec Is it possible to take a look? 😄

@kamilmysliwiec kamilmysliwiec merged commit 3812852 into nestjs:master Jul 2, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants