Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: less verbose 'missing packages' error message #2623

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Jul 2, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

npm i isn't supposed to be used when we're using another package manager. So this can be confusing to new nodejs devs out there.

What is the new behavior?

  • no hint on which command we should run to fix the error because it's misleading
  • Follows the same wording as the errors raised by @nestjs/common

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Following the same words are the errors raised by `@nestjs/common`
@kamilmysliwiec kamilmysliwiec merged commit f9f9d4c into nestjs:master Jul 3, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants